Skip to content

Add support for Pebble STM32F4 based boards#18

Merged
gmarull merged 4 commits intopebble-dev:mainfrom
Hexxeh:lmcloughlin/stm32f4
Feb 13, 2025
Merged

Add support for Pebble STM32F4 based boards#18
gmarull merged 4 commits intopebble-dev:mainfrom
Hexxeh:lmcloughlin/stm32f4

Conversation

@Hexxeh
Copy link
Collaborator

@Hexxeh Hexxeh commented Feb 12, 2025

With these changes and #15 you can do:

./waf configure --board=snowy_bb2 --nojs --nohash
./waf build
./waf flash
./waf console

The same has been tested for silk_bb2, but a further change is required to address a missing font.

Copy link
Collaborator

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, we should avoid adding big chunks of 3rd party code in the repo. Git submodules can be used to maintain certain isolation (see nrf case, or CMSIS). Reasons include potential license issues, vendor bad practices (adding binaries in git), etc.

@Hexxeh
Copy link
Collaborator Author

Hexxeh commented Feb 13, 2025

IMHO, we should avoid adding big chunks of 3rd party code in the repo. Git submodules can be used to maintain certain isolation (see nrf case, or CMSIS). Reasons include potential license issues, vendor bad practices (adding binaries in git), etc.

In the case of the ST CMSIS header and STM32 peripheral library, other than a handful of cases where people have dumped the contents of the archive from ST into a repo, these aren't available for us to submodule. We also need to modify some of the files for them to build correctly. We'd have to create our own repo to submodule them in.

Should I ask for a new repo to be created to contain these ST files on pebble-dev and submodule that?

@gmarull
Copy link
Collaborator

gmarull commented Feb 13, 2025

IMHO, we should avoid adding big chunks of 3rd party code in the repo. Git submodules can be used to maintain certain isolation (see nrf case, or CMSIS). Reasons include potential license issues, vendor bad practices (adding binaries in git), etc.

In the case of the ST CMSIS header and STM32 peripheral library, other than a handful of cases where people have dumped the contents of the archive from ST into a repo, these aren't available for us to submodule. We also need to modify some of the files for them to build correctly. We'd have to create our own repo to submodule them in.

Should I ask for a new repo to be created to contain these ST files on pebble-dev and submodule that?

Maybe something like https://github.com/zephyrproject-rtos/hal_stm32 could be created?

@Hexxeh Hexxeh force-pushed the lmcloughlin/stm32f4 branch 3 times, most recently from 23113ac to 1499a7e Compare February 13, 2025 10:39
Signed-off-by: Liam McLoughlin <hexxeh@hexxeh.net>
Signed-off-by: Liam McLoughlin <hexxeh@hexxeh.net>
Signed-off-by: Liam McLoughlin <hexxeh@hexxeh.net>
Signed-off-by: Liam McLoughlin <hexxeh@hexxeh.net>
@Hexxeh Hexxeh force-pushed the lmcloughlin/stm32f4 branch from 1499a7e to 402f95b Compare February 13, 2025 10:43
@gmarull gmarull merged commit dab84ac into pebble-dev:main Feb 13, 2025
2 checks passed
@Hexxeh Hexxeh deleted the lmcloughlin/stm32f4 branch February 13, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants