Add support for Pebble STM32F4 based boards#18
Conversation
gmarull
left a comment
There was a problem hiding this comment.
IMHO, we should avoid adding big chunks of 3rd party code in the repo. Git submodules can be used to maintain certain isolation (see nrf case, or CMSIS). Reasons include potential license issues, vendor bad practices (adding binaries in git), etc.
In the case of the ST CMSIS header and STM32 peripheral library, other than a handful of cases where people have dumped the contents of the archive from ST into a repo, these aren't available for us to submodule. We also need to modify some of the files for them to build correctly. We'd have to create our own repo to submodule them in. Should I ask for a new repo to be created to contain these ST files on pebble-dev and submodule that? |
Maybe something like https://github.com/zephyrproject-rtos/hal_stm32 could be created? |
23113ac to
1499a7e
Compare
Signed-off-by: Liam McLoughlin <hexxeh@hexxeh.net>
Signed-off-by: Liam McLoughlin <hexxeh@hexxeh.net>
Signed-off-by: Liam McLoughlin <hexxeh@hexxeh.net>
Signed-off-by: Liam McLoughlin <hexxeh@hexxeh.net>
1499a7e to
402f95b
Compare
With these changes and #15 you can do:
The same has been tested for silk_bb2, but a further change is required to address a missing font.