tools/pdc2png: Use the right size of size#311
Merged
hellcp merged 1 commit intopebble-dev:mainfrom Dec 16, 2025
Merged
Conversation
jwise
approved these changes
Dec 15, 2025
jwise
left a comment
jwise
left a comment
There was a problem hiding this comment.
I think size really should be uint32_t here but this is fully wrong on big endian anyway, so it's not more wrong in this case
Signed-off-by: Stasia Michalska <hel@lcp.world>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrong size of this causes a crash, which is not very useful