Proto communication david#2197
Merged
rnijveld merged 13 commits intoproto-communication-splitfrom Apr 16, 2026
Merged
Conversation
This will allow us to give the source access to the manager snapshots, which is needed to eventually move source usability into the per-source part of the algorithm interface.
This will eventually make it easier to make communication between source and ntp_manager more implicit, and reduces the amount of things the system struct is responsible for.
This is now no longer needed, and removing this reduces the work system needs to do a lot.
This removes the need for any messages between ntp manager and sources, which also allows the removal of several bits of the source-system communication in the daemon.
This further simplifies system, facilitating its removal.
This makes the updating of the ntp snapshot more robust by ensuring the latest data is available before it is used for synchronization.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## proto-communication-split #2197 +/- ##
=============================================================
+ Coverage 84.41% 84.43% +0.01%
=============================================================
Files 70 70
Lines 19757 19723 -34
=============================================================
- Hits 16678 16653 -25
+ Misses 3079 3070 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This further simplifies system, preparing for its removal.
This makes it impossible to forget to do this on dropping the source controller. It also simplifies system, which makes its removal easier.
This fixes incorrect strata being advertised by servers.
davidv1992
force-pushed
the
proto-communication-david
branch
from
18028b1 to
1ff3a1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.