Skip to content

added owner name to share code response #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
khoiddinh wants to merge 2 commits into
base: master
Choose a base branch
from
Open

added owner name to share code response #370

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d2146
added owner name to share code response
khoiddinh Nov 21, 2025
0b6a550
fixed linter issue
khoiddinh Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backend/gsr_booking/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,11 @@ def retrieve(self, request, *args, **kwargs):
)

serializer = self.get_serializer(share_code.booking)
return Response(serializer.data)
user = share_code.booking.user
Copy link
Copy Markdown
Contributor

@aangelinali aangelinali Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code creates a nested response structure that's not consistent with the other endpoints. it's also good practice for the serializer to define what data gets returned. instead of manually wrapping it like this, an easier and cleaner approach would be to add owner_name directly to SharedGSRBookingSerializer as a field

return Response({
"owner_name": f"{user.first_name} {user.last_name}",
"booking": serializer.data
})

# create() is inherited from CreateModelMixin
# destroy() is inherited from DestroyModelMixin
Loading