K8SPXC-1685: ignore failed validation when pvc resize is off#2407
Open
K8SPXC-1685: ignore failed validation when pvc resize is off#2407
Conversation
pooknull
requested review from
egegunes,
gkech,
hors,
mayankshah1607,
nmarukovich and
oksana-grishchenko
as code owners
egegunes
requested changes
Mar 30, 2026
Contributor
egegunes
left a comment
egegunes
left a comment
There was a problem hiding this comment.
@pooknull please implement enableExternalAutoscaling like in https://github.com/percona/percona-server-mongodb-operator/blob/main/deploy/cr.yaml#L16
| if cr.Spec.VolumeExpansionEnabled { | ||
| return err | ||
| } | ||
| log.Info(err.Error()) |
Contributor
There was a problem hiding this comment.
i don't think we should log anything in this case
egegunes
approved these changes
Apr 6, 2026
gkech
reviewed
Apr 9, 2026
| AllowUnsafeConfig bool `json:"allowUnsafeConfigurations,omitempty"` | ||
| Unsafe UnsafeFlags `json:"unsafeFlags,omitempty"` | ||
| VolumeExpansionEnabled bool `json:"enableVolumeExpansion,omitempty"` | ||
| VolumeExternalAutoscaling bool `json:"enableExternalAutoscaling,omitempty"` |
Contributor
There was a problem hiding this comment.
I think that since we are adding this option and since PVC resizing is coming, we can do something similar to what we did for PSMDB operator and introduce the target cr structure with the new option, together with the old. Then, once we implement the new feature, we will just complement the additional options.
So, something like this:
# storageScaling:
# enableExternalAutoscaling: false
# enableVolumeScaling: false
nmarukovich
approved these changes
Apr 27, 2026
Collaborator
commit: e9e1684 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://perconadev.atlassian.net/browse/K8SPXC-1685
DESCRIPTION
Problem:
PVC resize validation blocks reconcile when the
enableVolumeExpansionis false.Solution:
If
enableVolumeExpansionis false, log therequested storage (%s) is less than actual storage (%s)message instead of returning an error.Also this PR adds
.spec.enableExternalAutoscalingfield which has the same functionality as in thepsmdb-operatorHelm PR: percona/percona-helm-charts#824
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability