Skip to content

K8SPXC-1784 set the certificate privateKey rotationPolicy to Never#2448

Open
gkech wants to merge 5 commits intomainfrom
K8SPXC-1784
Open

K8SPXC-1784 set the certificate privateKey rotationPolicy to Never#2448
gkech wants to merge 5 commits intomainfrom
K8SPXC-1784

Conversation

@gkech
Copy link
Copy Markdown
Contributor

@gkech gkech commented Apr 29, 2026

Jira: https://perconadev.atlassian.net/browse/K8SPXC-1784

CHANGE DESCRIPTION

Problem:

Cert-manager version 1.18.0 introduced a change when rotating certificates. The default value of rotationPolicy was changed from 'Never' to 'Always'. With this PR we are hardcoding the rotationPolicy to 'Never' so that we keep the as it behaviour for newer cert manager versions. We may explore in the future the possibility of configuring that appropriately through exposing a cr option or something similar.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PXC version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size Bot added the size/S 10-29 lines label Apr 29, 2026
@gkech gkech marked this pull request as ready for review April 29, 2026 10:52
@pull-request-size pull-request-size Bot added size/M 30-99 lines and removed size/S 10-29 lines labels Apr 29, 2026
egegunes
egegunes previously approved these changes Apr 30, 2026
Copy link
Copy Markdown
Contributor

@egegunes egegunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't we already do this? was it another operator?

@egegunes egegunes added this to the v1.20.0 milestone Apr 30, 2026
@gkech
Copy link
Copy Markdown
Contributor Author

gkech commented Apr 30, 2026

didn't we already do this? was it another operator?

with the cert manager integration on pg operator, we also added this

nmarukovich
nmarukovich previously approved these changes Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M 30-99 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants