K8SPXC-1784 set the certificate privateKey rotationPolicy to Never#2448
Open
K8SPXC-1784 set the certificate privateKey rotationPolicy to Never#2448
Conversation
egegunes
previously approved these changes
Apr 30, 2026
Contributor
egegunes
left a comment
There was a problem hiding this comment.
didn't we already do this? was it another operator?
Contributor
Author
with the cert manager integration on pg operator, we also added this |
nmarukovich
previously approved these changes
Apr 30, 2026
nmarukovich
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://perconadev.atlassian.net/browse/K8SPXC-1784
CHANGE DESCRIPTION
Problem:
Cert-manager version 1.18.0 introduced a change when rotating certificates. The default value of rotationPolicy was changed from 'Never' to 'Always'. With this PR we are hardcoding the rotationPolicy to 'Never' so that we keep the as it behaviour for newer cert manager versions. We may explore in the future the possibility of configuring that appropriately through exposing a cr option or something similar.
Cause:
Short explanation of the root cause of the issue if applicable.
Solution:
Short explanation of the solution we are providing with this PR.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability