PMM-15015 Remove conflicting package declaration in pmm-client#5296
PMM-15015 Remove conflicting package declaration in pmm-client#5296
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #5296 +/- ##
==========================================
+ Coverage 42.10% 42.13% +0.02%
==========================================
Files 410 410
Lines 41992 41992
==========================================
+ Hits 17682 17694 +12
+ Misses 22525 22515 -10
+ Partials 1785 1783 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ademidoff
requested review from
JiriCtvrtka and
maxkondr
and removed request for
a team
| Requires(postun): systemd | ||
|
|
||
| AutoReq: no | ||
| Conflicts: pmm-client |
There was a problem hiding this comment.
It should contain version match <3.0.0
There was a problem hiding this comment.
This line was removed. What are you referring to?
There was a problem hiding this comment.
I suggest not removing it but just add Conflicts: pmm-client < 3.0.0
There was a problem hiding this comment.
That's exactly what we want to avoid. We actually want any newer version of the package called pmm-client, which is being installed, to replace any previous version, and not to conflict with it.
Unless I'm unaware of other benefits this may bring.
There was a problem hiding this comment.
This is exactly RPM pattern that is used for the behavior you want. Yes it will work with the only Obsoletes but it will fail in case enduser will execute rpm -i pmm-client.... So that is why Obsoletes and Conflicts are used together.
There was a problem hiding this comment.
Hm, I don't really understand why the user can't install PMM Client by running rpm -i pmm-client.
OK, thank you, we will QA this solution anyway.
There was a problem hiding this comment.
user can download package from repo or can copy it to a server from let's say USB drive as there are a lot of users that doesn't use repo to install packages.
There was a problem hiding this comment.
Pull request overview
This PR updates the RPM packaging for PMM Client by removing a self-referential Conflicts: pmm-client declaration from the spec file, addressing reported installation/upgrade conflicts (PMM-15015).
Changes:
- Removed
Conflicts: pmm-clientfrom thepmm-clientRPM spec to prevent erroneous package conflict behavior during install/upgrade.
PMM-15015
Ref: reported on the forum - https://forums.percona.com/t/pmm-client-v3-7-0-conflicting-with-itself/40715.
Link to the Feature Build: SUBMODULES-4326
This pull request makes a small change to the
pmm-client.specfile, removing theConflicts: pmm-clientline. This simplifies the package specification and may help avoid unnecessary package conflict errors during installation.