Skip to content

Update PULL_REQUEST_TEMPLATE.md #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: ros2-devel
Choose a base branch
from
Draft

Update PULL_REQUEST_TEMPLATE.md #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
- \[ \] `pre-commit run --all-files`
- \[ \] Run your code through [pylint](https://pylint.readthedocs.io/en/latest/). `pylint --recursive=y --rcfile=.pylintrc .`. All warnings but `fixme` must be addressed.

Note: When running code through `pylint`, it may be beneficial to compare the output from the base branch to the development branch by using a [diff checker](http://diffchecker.com/). To copy the output of `pylint` on Linux, you can use `pylint --recursive=y --rcfile=.pylintrc . | xsel -ib`

# Before Merging

- \[ \] `Squash & Merge`
Loading