Skip to content

Clang C++20 compatibility: made operator== and operator!= friend functions #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clang C++20 compatibility: made operator== and operator!= friend functions #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7bacb0
Turned operator== and operator!= members into friend functions for Cl…
JPenuchot Jan 20, 2022
66857ea
Added default constructor for non_copyable_thing that Clang doesn't g…
JPenuchot Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/ctpg/ctpg.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ namespace stdex
constexpr it_type* cast() { return static_cast<it_type*>(this); }
constexpr const it_type* cast() const { return static_cast<const it_type*>(this); }

constexpr bool operator == (const it_type& other) const { return cast()->ptr == other.ptr; }
constexpr bool operator != (const it_type& other) const { return cast()->ptr != other.ptr; }
constexpr friend bool operator == (it_type const& a, it_type const& b) { return a.cast()->ptr == b.cast()->ptr; }
constexpr friend bool operator != (it_type const& a, it_type const& b) { return a.cast()->ptr != b.cast()->ptr; }
constexpr it_type operator - (size_type amount) const { return it_type{ cast()->ptr - amount }; }
constexpr size_type operator - (const it_type& other) const { return size_type(cast()->ptr - other.ptr); }
constexpr it_type operator + (size_type amount) const { return it_type{ cast()->ptr + amount }; }
Expand Down
3 changes: 2 additions & 1 deletion tests/list_helpers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ namespace test
{
struct non_copyable_thing
{
non_copyable_thing() = default;
non_copyable_thing(const non_copyable_thing&) = delete;
non_copyable_thing& operator = (const non_copyable_thing&) = delete;

Expand Down Expand Up @@ -87,4 +88,4 @@ TEST_CASE("construct", "[list helpers]")

REQUIRE(result.has_value());
REQUIRE(result.value().size() == 4);
}
}