Skip to content

Conversation

robertramey
Copy link

…eve they are of general usage.


#include "detail/matches.h"
#include "detail/pp.h"
#include "integral_constant.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The include paths should not use relative paths.

RELATIVE "${CMAKE_CURRENT_SOURCE_DIR}"
"${CMAKE_CURRENT_SOURCE_DIR}/tick/detail/*.h"
)
add_custom_target(tick_include_detail SOURCES ${tick_include})
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't include all the header files, and I don't like the idea of creating a target for each include directory.

@pfultz2
Copy link
Owner

pfultz2 commented Aug 7, 2017

There is merge conflict, so this cannot be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants