Parallelize get_latest_dumps script with xargs#92
Open
rayrrr wants to merge 2 commits intophilipmat:masterfrom
Open
Parallelize get_latest_dumps script with xargs#92rayrrr wants to merge 2 commits intophilipmat:masterfrom
rayrrr wants to merge 2 commits intophilipmat:masterfrom
Conversation
Owner
|
The discogs team requires User-Agent for their API. I don't think it's required to download the zip files - is there a way we can make sure of it? |
Author
|
@philipmat thanks for the heads up! I will put it back. Is it cool if we make the User-Agent something simpler, like |
Author
|
Of interest: if we remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To maximize usage of bandwidth and make the download marginally faster, use
xargsin combination withwget.Also, remove
USER_AGENTas the parentheses don't play nice withxargs, and also becausewgetfunctions just fine without it.The output is a bit hectic, with the progress bars from the parallel processes constantly overwriting each other...but totally worth it IMHO :)