Skip to content
This repository was archived by the owner on Jul 23, 2025. It is now read-only.

Conversation

@jianlianggao
Copy link
Member

Updated new BATMAN docker container tag to fix bug of crash when input with small number of spectra (<=5 spectra) and BATMAN interactive tour

NOTE: I tried to follow other tools with help documentation in the batman.xml file, but failed to pass minikube test. I have to keep what it is.

Updated new BATMAN docker container tag to fix bug of crash when input with small number of spectra (<=5 spectra) and BATMAN interactive tour
Copy link
Member

@pcm32 pcm32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jianliang! There seems to be some issues with commit, too many changed lines in the job conf. Can you reset the branch and commit only the tour on one commit? Given the proximity to the release, can you please make a release of the batman container? So that we use a release tag a not a dev tag in this pull request? Thanks

<param id="type">python</param>
<param id="function">k8s_wrapper_xlarge</param>
</destination>
<plugins>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something wrong with this commit, this file should have such a large diff

@@ -0,0 +1,78 @@
id: batman-tour
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! looking forward to seeing this in action!

@pcm32
Copy link
Member

pcm32 commented Jan 27, 2018

@jianlianggao issue on job_conf is because you applied your changes over your old feature/batman branch, please avoid doing this as it garbles the commit history of the repo. Please create a new feature branch starting from an updated version of release/v17.09-pheno-cerebellin branch (so after switching to that branch, do a git pull) and there please commit the tour change and the tag change and make a new pull request to the release branch. And please, after all this, please delete your feature/batman branch in your local directory. In general, always please branch from an up-to-date version of the branch where you want to commit to in the end.

Please let me know, so that we can close this pull request in favour of the newer one you'll create.

@pcm32
Copy link
Member

pcm32 commented Jan 30, 2018

Closing in favour of #125 (that one needs to set the tag though).

@pcm32 pcm32 closed this Jan 30, 2018
@ilveroluca ilveroluca deleted the feature/batman branch October 1, 2018 14:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants