Add PHP 8 and Symfony 5.2 support.#19
Conversation
welcoMattic
left a comment
welcoMattic
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution!
Can you confirm that this Adapter works completely for translation management?
|
Great job ! I was waiting that for so long |
|
@ylcdx Did you make real tests against the Phrase API? |
yes, but not directly by I think it would have been easier to implement a Translation Providers for Phrase directly (symfony/symfony#38475) ;) |
|
Hm, I see we have Travis config file in this repo but I don't see any Travis checks in this PR - only failed Scrutinizer. Probably Travis isn't activated for this repo? |
|
@ylcdx Yes, I think it is. If you want to start/do it, feel free to contact me on Symfony Devs Slack it you need help 👍 |
|
@bocharsky-bw We should move from Travis.org as it will be shutdown in the 15th of June |
4 participants
Fixes: #12