Refactor ComposerPhpVersionFactory, ConstantResolver #3627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
refactor-versions
branch
from
3cd6817 to
ae37f41
Compare
Collaborator
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Nov 12, 2024
src/Analyser/ConstantResolver.php
Outdated
| private ?PhpVersion $composerMinPhpVersion, | ||
| private ?PhpVersion $composerMaxPhpVersion, | ||
| private int|array|null $phpVersion, | ||
| private ?ComposerPhpVersionFactory $composerPhpVersionFactory, |
Contributor
Author
There was a problem hiding this comment.
to allow creation of the ConstantResolver when the DI is not yet constructed
Member
There was a problem hiding this comment.
Just pass new ComposerPhpVersionFactory with empty $composerAutoloaderProjectPaths there.
ondrejmirtes
requested changes
Nov 12, 2024
src/Analyser/ConstantResolver.php
Outdated
| ) { | ||
| $minRelease = $this->composerMinPhpVersion->getPatchVersionId(); | ||
| $maxRelease = $this->composerMaxPhpVersion->getPatchVersionId(); | ||
| $minRelease = $this->getMinPhpVersion()->getPatchVersionId(); |
Member
There was a problem hiding this comment.
You're calling the getter multiple times and it always leads to creating new object. I'd just do if (in_array($resolvedConstantName, ['PHP_VERSION_ID', 'PHP_MAJOR_VERSION', 'PHP_MINOR_VERSION'])) and save it to a variable first, then use the variable. inside for each constant.
clxmstaab
force-pushed
the
refactor-versions
branch
from
2ddbff8 to
38856cb
Compare
staabm
force-pushed
the
refactor-versions
branch
from
38856cb to
750aebf
Compare
staabm
force-pushed
the
refactor-versions
branch
from
750aebf to
73d0b16
Compare
Member
|
Thank you! Now onto the diagnose command :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as requested in #3609 (review)