Skip to content

Introduce reportArrayKeyCast parameter #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.1.x
Choose a base branch
from
Open

Introduce reportArrayKeyCast parameter #4012

wants to merge 1 commit into from

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented May 24, 2025 •
edited
Loading

Closes phpstan/phpstan#12589
Closes phpstan/phpstan#7884
Closes phpstan/phpstan#7864

Naming is opened to discussion.

I think we could enable this in phpstan-strict-rules.

@VincentLanglet VincentLanglet force-pushed the reportCastedArrayKey branch from f56eb92 to 011505b Compare May 24, 2025 11:59
ondrejmirtes
ondrejmirtes requested changes Jul 17, 2025
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also would be nice if it observed rule levels. Always wrong type like null to be always reported, but a partially wrong type like string|stdClass only on level 7+...

This is achieved with RuleLevelHelper::findTypeToCheck.

@VincentLanglet VincentLanglet force-pushed the reportCastedArrayKey branch 2 times, most recently from 692ddc0 to a5aea3c Compare July 17, 2025 20:08
@VincentLanglet
Copy link
Contributor Author

Seems like the RuleLevelHelper::findTypeToCheck was not used at all (or wrongly used) on theses rules.

So I fixed it and added tests with and without the reportArrayKeyCast option.

@VincentLanglet VincentLanglet marked this pull request as draft July 26, 2025 16:13
@VincentLanglet VincentLanglet mentioned this pull request Jul 26, 2025
Merged
@ondrejmirtes ondrejmirtes mentioned this pull request Jul 30, 2025
Open
@VincentLanglet
Copy link
Contributor Author

Current status, waiting #4166 first

@VincentLanglet VincentLanglet changed the title Introduce reportCastedArrayKey parameter Introduce reportArrayKeyCast parameter Sep 10, 2025
@VincentLanglet VincentLanglet marked this pull request as ready for review September 10, 2025 18:00
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@VincentLanglet
Copy link
Contributor Author

This is finally ready to be reviewed @ondrejmirtes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes Awaiting requested review from ondrejmirtes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@VincentLanglet @phpstan-bot @ondrejmirtes