Skip to content

Fix ImpossibleInstanceOfRule #4154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 2.1.x
Choose a base branch
from

Conversation

VincentLanglet
Copy link
Contributor

Closes phpstan/phpstan#10036

Closes #2769

Seems like it was implemented but ignored because of an early return.
I just fixed it and add it the usage of the rule levelhelper.

Copy link
Contributor

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking over!

@VincentLanglet VincentLanglet requested a review from staabm July 24, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

instanceof $class not reported as an error when $class is string|null
2 participants