Validate curl_setopt_array parameter array #4395
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Oct 1, 2025
Comment on lines
1389
to
1394
| [ | ||
| "Parameter #2 \$options of function curl_setopt_array expects array{19913: bool, 10102: string, 68: int, 13: int, 84: int, 10036: non-empty-string|null}, array{19913: true, 10102: '', 68: 10, 13: 30, 84: 2, 10036: CurlSetOptArray\BackedRequestMethod::POST} given.", | ||
| 42, | ||
| "Offset 10036 (non-empty-string|null) does not accept type CurlSetOptArray\BackedRequestMethod::POST." | ||
| ], |
There was a problem hiding this comment.
tbh, I did not expect this error, but as it also is emitted for regular parameter types when given a string backed enum, it seems we should have it
clxmstaab
force-pushed
the
curl-opt-array
branch
from
514666c to
f3210ff
Compare
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
curl-opt-array
branch
2 times, most recently
from
59cd1a5 to
142d4e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #1719
closes phpstan/phpstan#13615