Skip to content

Support union types in curl_setopt validation #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

Support union types in curl_setopt validation #4396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c214b52
Support union types in curl_setopt validation
staabm Oct 1, 2025
8f64189
Update ParametersAcceptorSelector.php
staabm Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 40 additions & 26 deletions src/Reflection/ParametersAcceptorSelector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
use function constant;
use function count;
use function defined;
use function is_int;
use function is_string;
use function sprintf;
use const ARRAY_FILTER_USE_BOTH;
Expand Down Expand Up @@ -126,33 +127,46 @@ public static function selectFromArgs(

if (count($args) >= 3 && (bool) $args[0]->getAttribute(CurlSetOptArgVisitor::ATTRIBUTE_NAME)) {
$optType = $scope->getType($args[1]->value);
if ($optType instanceof ConstantIntegerType) {
$optValueType = self::getCurlOptValueType($optType->getValue());

if ($optValueType !== null) {
$acceptor = $parametersAcceptors[0];
$parameters = $acceptor->getParameters();

$parameters[2] = new NativeParameterReflection(
$parameters[2]->getName(),
$parameters[2]->isOptional(),
$optValueType,
$parameters[2]->passedByReference(),
$parameters[2]->isVariadic(),
$parameters[2]->getDefaultValue(),
);

$parametersAcceptors = [
new FunctionVariant(
$acceptor->getTemplateTypeMap(),
$acceptor->getResolvedTemplateTypeMap(),
array_values($parameters),
$acceptor->isVariadic(),
$acceptor->getReturnType(),
$acceptor instanceof ExtendedParametersAcceptor ? $acceptor->getCallSiteVarianceMap() : TemplateTypeVarianceMap::createEmpty(),
),
];

$valueTypes = [];
foreach ($optType->getConstantScalarValues() as $scalarValue) {
if (!is_int($scalarValue)) {
$valueTypes = [];
break;
}

$valueType = self::getCurlOptValueType($scalarValue);
if ($valueType === null) {
$valueTypes = [];
break;
}

$valueTypes[] = $valueType;
}

if (count($valueTypes) !== 0) {
$acceptor = $parametersAcceptors[0];
$parameters = $acceptor->getParameters();

$parameters[2] = new NativeParameterReflection(
$parameters[2]->getName(),
$parameters[2]->isOptional(),
TypeCombinator::union(...$valueTypes),
$parameters[2]->passedByReference(),
$parameters[2]->isVariadic(),
$parameters[2]->getDefaultValue(),
);

$parametersAcceptors = [
new FunctionVariant(
$acceptor->getTemplateTypeMap(),
$acceptor->getResolvedTemplateTypeMap(),
array_values($parameters),
$acceptor->isVariadic(),
$acceptor->getReturnType(),
$acceptor instanceof ExtendedParametersAcceptor ? $acceptor->getCallSiteVarianceMap() : TemplateTypeVarianceMap::createEmpty(),
),
];
}
}

Expand Down
4 changes: 4 additions & 0 deletions tests/PHPStan/Rules/Functions/CallToFunctionParametersRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,6 +1375,10 @@ public function testCurlSetOpt(): void
'Parameter #3 $value of function curl_setopt expects array<int, string>, array<string, string> given.',
77,
],
[
'Parameter #3 $value of function curl_setopt expects bool|int, int|string given.',
96,
],
]);
}

Expand Down
14 changes: 14 additions & 0 deletions tests/PHPStan/Rules/Functions/data/curl_setopt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,18 @@ public function bug9263() {
];
curl_setopt($curl, CURLOPT_HTTPHEADER, $header_list);
}

public function unionType() {
$curl = curl_init();

if (rand(0,1)) {
$var = CURLOPT_AUTOREFERER;
$value = 'yes'; // invalid, should be bool
} else {
$var = CURLOPT_TIMEOUT;
$value = 1;
}

curl_setopt($curl, $var, $value);
}
}
Loading