string cast might throw exception

[canvural]

closes phpstan/phpstan#13806

[staabm]

the rfc is PHP 7.4+, meaning this logic should be gated via PHPVersion class.

note though, that NodeScopeResolver is undergoing a major refactoring atm, so this might conflict easily

[ondrejmirtes]

It won't conflict, I'm not doing any major changes in NodeScopeResolver that I'm not pushing.

But it's possible that the same change also needs to happen in PHPStan\Analyser\Generator namespace. In this case it doesn't because there's no StringCastHandler ported yet.

[canvural]

I thought the minimum version PHPStan supports was 7.4 Is it 7.1?

[staabm]

there are 2 things.

the php version PHPStan can analyze against, configured in the .neon config:

phpstan-src/conf/parametersSchema.neon

Line 103 in 5afb019

schema(int(), min(70100), max(80599)),

and the PHP runtime version you use to run PHPStan itself:
https://github.com/phpstan/phpstan/blob/5afb019da9f70ae5a2b4247a1830b5103423a325/composer.json#L7

[VincentLanglet]

I feel like this lack of test,

It should add a test for

function doFoo(Stringable $myVariable): void

to check the implicit throw tag

and a test for

class MyStringVoid {
	/** @throws void */
	public function __toString() {
		throw new \InvalidArgumentException();
	}
}

to check in this case the catch is reported as dead catch

[phpstan-bot]

This pull request has been marked as ready for review.

[VincentLanglet]

Does it also solve phpstan/phpstan#5952 ?
You could add a test for this issue :)