Skip to content

Conversation

@aqlina
Copy link
Collaborator

@aqlina aqlina commented Jan 27, 2026

Steps to reproduce:

devtools::load_all()


library(tibble)
#'
ADSL <- jnj_ex_adsl
ADEX <- jnj_ex_adexsum
ADAE <- jnj_ex_adae
#'
app <- teal::init(
  data = teal.data::cdisc_data(
    ADSL = ADSL,
    ADAE = ADAE,
    ADEX = ADEX,
    code = "
     ADSL <- jnj_ex_adsl
     ADEX <- jnj_ex_adexsum
     ADAE <- jnj_ex_adae
    "
  ),
  modules = teal::modules(
    tm_t_incidence_j(
      label = "JNJ Patient yea
      rs",
      transformators = list(uteals::merge_column_levels_transformator("ADEX")),
      decorators = list(table = title_footer_decorator("table",
        titles_file = system.file("titles.xlsx",
          package = "teal.modules.clinical.junco"
        )
      ))
    )
  )
)
if (interactive()) {
  shiny::shinyApp(app$ui, app$server)
}

Scenario 1:

  1. Run the merge column level transformator example.
  2. Select TRTA01, select High dose and low dose as levels and give label.
  3. Once the transformation is applied , click on Reset button.

Ouput : The merge levels and label value are not resetting.
Expected: The merge levels and label value will reset.

  1. Click on "x" close button to remove
    Output: The app crashes with the error.
    Expected: App shouldn't crash and should remove the UI for levels and label.

Scenario 2:
Repeat steps 1 to 3 again.
After rest, click on selected column to choose another column.
Output : The app crashes
Expected: New UI for the selected column should be displayed.

@Pranith1785
Copy link
Collaborator

@aqlina Reviewed the code.
select "TRT01A" and levels "high dose and lose dose" and label as "test", click apply. the table is getting updated correctly. Now the issue is

  1. click on 'x' button to remove changes, we are closing the select dropdown inputs and when selecting another column, then app crashes
  2. now click "Reset" button, then table got updated correctly, but the selected inputs are not lost

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2026

badge

Code Coverage Summary

Filename                                     Stmts    Miss  Cover    Missing
-----------------------------------------  -------  ------  -------  ---------
R/BlockConditions.R                             14      14  0.00%    23-54
R/create_rel_risk_transformator.R               43      43  0.00%    35-83
R/forest_plot_decorator.R                      164     164  0.00%    97-368
R/ggplot_decorator.R                           244     244  0.00%    81-352
R/merge_levels_transformator.R                 222     222  0.00%    38-293
R/or_filtering_transformator_view_model.R       27      27  0.00%    26-64
R/or_filtering_transformator.R                 254     254  0.00%    64-364
R/patchwork_plot_decorator.R                    46      46  0.00%    16-66
R/r_access_utilities.R                          45      45  0.00%    25-142
R/title_footer_decorator.R                     123     123  0.00%    31-159
TOTAL                                         1182    1182  0.00%

Diff against main

Filename                          Stmts    Miss  Cover
------------------------------  -------  ------  --------
R/merge_levels_transformator.R      -38     -38  +100.00%
TOTAL                               -38     -38  +100.00%

Results for commit: 640a5e5

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@aqlina aqlina force-pushed the feature/jgqo-386-bugfix-merge-transfr branch from 9378503 to 640a5e5 Compare January 29, 2026 08:05
Copy link
Collaborator

@Pranith1785 Pranith1785 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wroking fine as per the changes done

@aqlina aqlina merged commit f014913 into main Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants