Skip to content

Add list of common labels#23

Open
yubiuser wants to merge 2 commits intomasterfrom
labels
Open

Add list of common labels#23
yubiuser wants to merge 2 commits intomasterfrom
labels

Conversation

@yubiuser
Copy link
Member

@yubiuser yubiuser commented Jan 6, 2023

What does this PR aim to accomplish?:

Adds a list of common labels used across all Pi-hole repos


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <[email protected]>
@yubiuser yubiuser requested a review from a team January 6, 2023 09:29
@PromoFaux
Copy link
Member

I don't remember where we got to with discussion around meta info like this. Does this have any functional value or does it serve as a list for manual reference?

Co-authored-by: Adam Warner <[email protected]>
Signed-off-by: yubiuser <[email protected]>
@yubiuser
Copy link
Member Author

This is just a manual list we agreed to adhere to. I think there is some kind of org-wide label system, but it includes just the common labels - each repo is free to change and add as it wants. This does not prevent us from using divergent labels which can (and did) cause issues with the workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants