Add MAC addresses and comments to Top Clients tables#3649
Open
cpeintre wants to merge 2 commits intopi-hole:masterfrom
Open
Add MAC addresses and comments to Top Clients tables#3649cpeintre wants to merge 2 commits intopi-hole:masterfrom
cpeintre wants to merge 2 commits intopi-hole:masterfrom
Conversation
Display MAC addresses and client comments in both Top Clients (total) and Top Clients (blocked only) tables on the homepage. This provides more detailed information about clients at a glance without needing to navigate to separate pages.
Modified updateTopClientsTable() to fetch client metadata from both /clients and /clients/_suggestions APIs to populate MAC addresses and comments columns. The function now: - Fetches configured clients to get comments - Fetches client suggestions to map IPs to MAC addresses - Merges this metadata with top clients statistics - Gracefully handles API failures by showing table without metadata This ensures the new columns are populated with actual data.
Member
|
You need to fix your PR. Please check the failing tests. Also, can you provide a screenshot of the tables including the suggested changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Display MAC addresses and client comments in both Top Clients (total) and Top Clients (blocked only) tables on the homepage. This provides more detailed information about clients at a glance without needing to navigate to separate pages.
Thank you for your contribution to the Pi-hole Community!
Please read the comments below to help us consider your Pull Request.
We are all volunteers and completing the process outlined will help us review your commits quicker.
Please make sure you
What does this PR aim to accomplish?:
How does this PR accomplish the above?:
Link documentation PRs if any are needed to support this PR:
By submitting this pull request, I confirm the following:
git rebase)