macOS 11.x crash: WKWebViewConfiguration.upgradeKnownHostsToHTTPS unrecognized selector#2767
Open
liuyanqing wants to merge 1 commit intopichillilorenzo:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix crash on macOS 11.x caused by calling
WKWebViewConfiguration.upgradeKnownHostsToHTTPSwhen the selector is not available at runtime.
Details
Although
upgradeKnownHostsToHTTPSis marked asAPI_AVAILABLE(macos(11.3))in the SDK headers,the corresponding Objective-C selector
setUpgradeKnownHostsToHTTPS:is missing fromWebKit at runtime on macOS 11.x (Big Sur).
Calling it results in:
-[WKWebViewConfiguration setUpgradeKnownHostsToHTTPS:]: unrecognized selector sent to instance
This PR guards the assignment with a runtime selector check,
preventing the crash while preserving behavior on macOS 12+.
Affected platforms
Refs #2741