fix: modernize stop command with label-based container discovery#8
Merged
fix: modernize stop command with label-based container discovery#8
Conversation
- Replace getContainerName() with discoverAllAisanityContainers() using workspace mode - Add branch filtering to stop only containers for current branch - Remove all legacy fallback logic (devcontainer and workspace name patterns) - Update function to async for Promise-based discovery API - Add clear error messaging when no containers found for branch - Preserve existing --worktree and --all-worktrees options - Use stopContainers() utility for efficient batch operations Fixes 'No such container: aisanity-cleanup' errors by using modern label-based discovery instead of generated container names. BREAKING CHANGE: Default stop behavior now only stops containers for current branch instead of all workspace containers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 'No such container: aisanity-cleanup' errors by using modern
label-based discovery instead of generated container names.