[RFC] Import upstream parser changes to parse deeply nested Json without st…#6
Draft
Numpsy wants to merge 1 commit intopimbrouwers:masterfrom
Draft
[RFC] Import upstream parser changes to parse deeply nested Json without st…#6Numpsy wants to merge 1 commit intopimbrouwers:masterfrom
Numpsy wants to merge 1 commit intopimbrouwers:masterfrom
Conversation
…ack overflows Imports the changes in fsprojects/FSharp.Data#1225 fsprojects/FSharp.Data#1411 from FSharp.Data, to allow parsing of more deeply nested Json structures without a stack overflow
Numpsy
commented
Aug 24, 2025
| |> Json.parse | ||
| |> ignore | ||
|
|
||
| [<Fact(Skip = "Requires TailCAlls to be enabled")>] |
Contributor
Author
There was a problem hiding this comment.
Note:
TailCalls need to be enabled in the library build to get these tests to pass, and those are only enabled in release builds by default (FSharp.Data has them enabled in debug builds as well - see comments in fsprojects/FSharp.Data#1411).
It also looks like you need to use XUnit v3 to be able to mark the tests as Explicit rather than just skiping them
Contributor
Author
Saying that, this approach does seem to allocate somewhate more memory during parsing :-( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ack overflows
Imports the changes in
fsprojects/FSharp.Data#1225
fsprojects/FSharp.Data#1411
from FSharp.Data, to allow parsing of more deeply nested Json structures without a stack overflow.
Just a thought when looking at the differences between the two parsers, as it seemed like it might be a useful change to have?