refactor: move pkg/ to internal/ with root package facade#5
Merged
luigi-agosti merged 1 commit intomainfrom Mar 25, 2026
Merged
refactor: move pkg/ to internal/ with root package facade#5luigi-agosti merged 1 commit intomainfrom
luigi-agosti merged 1 commit intomainfrom
Conversation
- pkg/portal/ → internal/engine/ (all implementation hidden) - pkg/quality/ → internal/quality/ - New seaportal.go root facade — thin public API with type aliases - Consumers now: import "github.com/pinchtab/seaportal" - CLI updated to use root package - All tests passing
luigiagent
force-pushed
the
refactor/internal-structure
branch
from
1eb284a to
6186904
Compare
luigi-agosti
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernises the project structure following Go conventions: implementation in
internal/, clean public API at the root.Changes
pkg/portal/→internal/engine/(all implementation hidden from importers)pkg/quality/→internal/quality/seaportal.goroot facade — thin public API with type aliases and delegate functionsgithub.com/pinchtab/seaportal(root package)Before / After
What's in the root facade
Types:
Result,Options,PageProfile,SnapshotNode,DedupeResult, etc. (all via type aliases)Functions:
FromURL,FromURLWithOptions,ExtractFromHTML,ClassifyPage,BuildSnapshot,Dedupe,CleanupMarkdown,ValidateExtraction, etc.All tests passing.