Audit checklist: 6 more sections (determinism, edge cases, offline, logging, deps, license)#34
Merged
lucapinello merged 1 commit intochorus-applicationsfrom Apr 21, 2026
Conversation
…ffline, logging, deps, license) Extends audits/AUDIT_CHECKLIST.md with sections the v18 version skipped but that actually matter for a scientific library release: - §13 Scientific determinism — same input twice → same output, known-good ±0.006 CPU non-det band across machines. - §14 Genomics edge cases — variant near telomere, soft-masked FASTA, multi-allelic, indels (error before model run, not after), chrM/chrY. - §15 Offline / air-gapped — predict/analyze_gene_expression without network; grep for CDN references in shipped HTMLs. - §16 Logging hygiene — no HF_TOKEN or AWS keys in committed outputs (grep pattern provided). - §17 Dependency supply chain — env.yml pins, pip-audit, per-oracle editable install. - §18 License / attribution — LICENSE, third-party model credits, bundled vendor JS license headers. Deliberately excluded: fuzzing, Windows support, concurrency, Docker, accessibility — out of scope for a scientific-lib release. Every added item has either a one-line grep/script or is a yes/no human check. No new audit-for-the-sake-of-audit items. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows up v18 (PR #33, merged) by adding six sections to
audits/AUDIT_CHECKLIST.mdthat a real release audit needs but the first pass skipped:environment.ymlpins,pip-audit, per-oracle editable install consistency.LICENSE, third-party model credits, bundled IGV JS license header.Deliberately excluded because they're out of scope for a scientific-lib release by a small team: fuzzing, Windows, concurrency benchmarks, Docker, accessibility testing. The user's constraint — "don't add things that would be unreasonable to test" — shaped this.
Every added item is either a one-line grep/script or a clear yes/no human check. No make-work.
Test plan
pytestunaffectedgrep -n '^## ' audits/AUDIT_CHECKLIST.mdconfirms the new sections land where expected🤖 Generated with Claude Code