types: speedup error generation to improve performance#64271
types: speedup error generation to improve performance#64271ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
Conversation
|
Hi @GMHDBJD. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #64271 +/- ##
================================================
+ Coverage 72.7412% 73.7785% +1.0373%
================================================
Files 1859 1862 +3
Lines 503989 509484 +5495
================================================
+ Hits 366608 375890 +9282
+ Misses 115120 111559 -3561
+ Partials 22261 22035 -226
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
D3Hunter
left a comment
There was a problem hiding this comment.
please paste the performance test result too
|
Seems types package mixes |
create a enhancement #64315 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
|
@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@joechenrh: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #64270
Problem Summary:
What changed and how does it work?
before this pr


after this pr
See toddstoffel/analytics_benchmark#5 for more details.
Check List
Tests
orignal test covert it.
tidb/pkg/expression/builtin_cast_test.go
Line 112 in e2d602a
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.