Skip to content

br: fix bug file-not-found error for gcs#65058

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
JoyC-dev:retry_failure_1216
Dec 31, 2025
Merged

br: fix bug file-not-found error for gcs#65058
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
JoyC-dev:retry_failure_1216

Conversation

@JoyC-dev
Copy link
Copy Markdown
Contributor

@JoyC-dev JoyC-dev commented Dec 16, 2025

What problem does this PR solve?

Issue Number: close #63567

Problem Summary: retry br log truncate, it may fail forever, only for gcs storage

What changed and how does it work?

deal with file-not-exist situation correctly as it has been deleted which should return no-error.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2025
@pingcap-cla-assistant
Copy link
Copy Markdown

pingcap-cla-assistant Bot commented Dec 16, 2025

CLA assistant check
All committers have signed the CLA.

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Dec 16, 2025

Hi @JoyC-dev. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BornChanger BornChanger changed the title fix bug file-not-found error for gcs, it should be idempotent as dele… fix bug file-not-found error for gcs Dec 16, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.6794%. Comparing base (11e53f2) to head (084ca2b).
⚠️ Report is 113 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #65058        +/-   ##
================================================
+ Coverage   70.8825%   71.6794%   +0.7969%     
================================================
  Files          1889       1903        +14     
  Lines        516133     523037      +6904     
================================================
+ Hits         365848     374910      +9062     
+ Misses       125845     123810      -2035     
+ Partials      24440      24317       -123     
Flag Coverage Δ
integration 48.3534% <20.0000%> (+0.2120%) ⬆️
unit 66.4730% <100.0000%> (+0.8325%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.8700% <ø> (ø)
parser ∅ <ø> (∅)
br 59.3222% <100.0000%> (-0.0307%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 16, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 17, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Dec 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-16 04:46:23.686276424 +0000 UTC m=+1534728.500053986: ☑️ agreed by YuJuncen.
  • 2025-12-17 06:07:06.649004372 +0000 UTC m=+1625971.462781944: ☑️ agreed by Leavrth.

@Leavrth Leavrth changed the title fix bug file-not-found error for gcs br: fix bug file-not-found error for gcs Dec 17, 2025
@lance6716
Copy link
Copy Markdown
Contributor

/retest

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Dec 17, 2025

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lance6716
Copy link
Copy Markdown
Contributor

Please sign CLA. Seems your git commits use a different email @JoyC-dev

@Leavrth
Copy link
Copy Markdown
Contributor

Leavrth commented Dec 18, 2025

/ok-to-test

@ti-chi-bot ti-chi-bot Bot added the ok-to-test Indicates a PR is ready to be tested. label Dec 18, 2025
@hawkingrei
Copy link
Copy Markdown
Member

/test all

@Leavrth
Copy link
Copy Markdown
Contributor

Leavrth commented Dec 22, 2025

/retest

3 similar comments
@Leavrth
Copy link
Copy Markdown
Contributor

Leavrth commented Dec 23, 2025

/retest

@Leavrth
Copy link
Copy Markdown
Contributor

Leavrth commented Dec 24, 2025

/retest

@hawkingrei
Copy link
Copy Markdown
Member

/retest

@hawkingrei
Copy link
Copy Markdown
Member

/retest

@ti-chi-bot ti-chi-bot Bot merged commit 014ed7b into pingcap:master Dec 31, 2025
83 of 100 checks passed
@Leavrth Leavrth added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. labels Jan 5, 2026
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #65404.

@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #65405.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 5, 2026
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #65406.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 5, 2026
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #65407.
But this PR has conflicts, please resolve them!

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jan 5, 2026
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #65408.
But this PR has conflicts, please resolve them!

@ti-chi-bot ti-chi-bot Bot removed the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jan 5, 2026
ti-chi-bot Bot pushed a commit that referenced this pull request Jan 7, 2026
Reminiscent pushed a commit to Reminiscent/tidb that referenced this pull request Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the retry of log truncate failed forever if there is too many files deleted before log truncated

6 participants