Skip to content

docs: replace deprecated PingCAP domains#67525

Open
wuhuizuo wants to merge 2 commits intorelease-7.5from
fix/update-pingcap-domains-release-7-5
Open

docs: replace deprecated PingCAP domains#67525
wuhuizuo wants to merge 2 commits intorelease-7.5from
fix/update-pingcap-domains-release-7-5

Conversation

@wuhuizuo
Copy link
Copy Markdown
Contributor

@wuhuizuo wuhuizuo commented Apr 2, 2026

What problem does this PR solve?

Issue Number: ref #67527

Problem Summary:

download.pingcap.org is being deprecated in favor of download.pingcap.com, and release-7.5 still has old-domain references in Dumpling install/docs and BR test download helpers.

What changed and how does it work?

  • backport the domain migration from master to release-7.5
  • replace deprecated download.pingcap.org references with download.pingcap.com in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
  • preserve the existing release-7.5-specific script behavior while only changing the download host

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test steps:

  • git diff --check
  • verify no remaining old-domain references in br/tests/download_tools.sh, dumpling/README.md, and dumpling/install.sh
  • curl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gz
  • curl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz
  • curl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gz
  • curl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gz

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

none

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 2, 2026

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be LGTMed and approved by the reviewers firstly.
  2. For pull requests to TiDB-x branches, it must have no failed tests.
  3. AFTER it has lgtm and approved labels, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 2, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign leavrth, lichunzhu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tiprow
Copy link
Copy Markdown

tiprow Bot commented Apr 2, 2026

Hi @wuhuizuo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot Bot added the component/dumpling This is related to Dumpling of TiDB. label Apr 2, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 2, 2026

📝 Walkthrough

Walkthrough

Updated download hosts in multiple scripts and docs: references to download.pingcap.org were changed to download.pingcap.com. No other logic, extraction, or file-placement operations were modified.

Changes

Cohort / File(s) Summary
BR test script
br/tests/download_tools.sh
Replaced https://download.pingcap.org/... with https://download.pingcap.com/... for nightly binaries (tiflash, tidb bundle via MISSING_TIDB_COMPONENTS, ticdc). Extraction and cleanup unchanged.
Dumpling README
dumpling/README.md
Updated example/instructions download URLs from .org to .com for bin/sync_diff_inspector, bin/tidb-server, and bin/tidb-lightning.
Dumpling install script
dumpling/install.sh
Changed wget source for tidb-toolkit-$TOOLS_TAG-linux-amd64.tar.gz from download.pingcap.org to download.pingcap.com; extraction and mv bin/* unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped from .org to .com today,
URLs rebounded in a merry display,
Tarballs untouched, extracts still the same,
A tiny domain hop, but the workflow's flame,
Nibble, test, and then away I play.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs: replace deprecated PingCAP domains' clearly summarizes the main change—updating download URLs from deprecated .org domain to .com domain across documentation and scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description provides a clear problem statement, itemized changes, manual test steps, and follows the required template structure with completed sections.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/update-pingcap-domains-release-7-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
dumpling/README.md (1)

37-39: Inconsistent protocol: http:// vs https://.

Line 37 uses http:// while lines 38-39 use https://. Consider using https:// consistently for all download URLs unless the enterprise-tools endpoint specifically requires HTTP.

Suggested fix
-    * `bin/sync_diff_inspector` (download from [tidb-enterprise-tools-latest-linux-amd64](http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz))
+    * `bin/sync_diff_inspector` (download from [tidb-enterprise-tools-latest-linux-amd64](https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz))
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@dumpling/README.md` around lines 37 - 39, Update the README entry for
`bin/sync_diff_inspector` to use HTTPS like the other links: replace the
`http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
URL with
`https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
so the `bin/sync_diff_inspector` bullet uses the same secure protocol as the
`bin/tidb-server` and `bin/tidb-lightning` entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@dumpling/README.md`:
- Around line 37-39: Update the README entry for `bin/sync_diff_inspector` to
use HTTPS like the other links: replace the
`http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
URL with
`https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
so the `bin/sync_diff_inspector` bullet uses the same secure protocol as the
`bin/tidb-server` and `bin/tidb-lightning` entries.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a2286db8-c750-44db-8977-1f36ae385755

📥 Commits

Reviewing files that changed from the base of the PR and between 81d74e6 and 5a0954f.

📒 Files selected for processing (3)
  • br/tests/download_tools.sh
  • dumpling/README.md
  • dumpling/install.sh

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Apr 2, 2026

@wuhuizuo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test f7df120 link true /test unit-test
idc-jenkins-ci-tidb/check_dev f7df120 link true /test check-dev

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/dumpling This is related to Dumpling of TiDB. do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant