docs: replace deprecated PingCAP domains#67525
Conversation
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @wuhuizuo. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughUpdated download hosts in multiple scripts and docs: references to Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
dumpling/README.md (1)
37-39: Inconsistent protocol:http://vshttps://.Line 37 uses
http://while lines 38-39 usehttps://. Consider usinghttps://consistently for all download URLs unless the enterprise-tools endpoint specifically requires HTTP.Suggested fix
- * `bin/sync_diff_inspector` (download from [tidb-enterprise-tools-latest-linux-amd64](http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz)) + * `bin/sync_diff_inspector` (download from [tidb-enterprise-tools-latest-linux-amd64](https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz))🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@dumpling/README.md` around lines 37 - 39, Update the README entry for `bin/sync_diff_inspector` to use HTTPS like the other links: replace the `http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz` URL with `https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz` so the `bin/sync_diff_inspector` bullet uses the same secure protocol as the `bin/tidb-server` and `bin/tidb-lightning` entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@dumpling/README.md`:
- Around line 37-39: Update the README entry for `bin/sync_diff_inspector` to
use HTTPS like the other links: replace the
`http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
URL with
`https://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gz`
so the `bin/sync_diff_inspector` bullet uses the same secure protocol as the
`bin/tidb-server` and `bin/tidb-lightning` entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a2286db8-c750-44db-8977-1f36ae385755
📒 Files selected for processing (3)
br/tests/download_tools.shdumpling/README.mddumpling/install.sh
|
@wuhuizuo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: ref #67527
Problem Summary:
download.pingcap.orgis being deprecated in favor ofdownload.pingcap.com, and release-7.5 still has old-domain references in Dumpling install/docs and BR test download helpers.What changed and how does it work?
masterto release-7.5download.pingcap.orgreferences withdownload.pingcap.cominbr/tests/download_tools.sh,dumpling/README.md, anddumpling/install.shCheck List
Tests
Manual test steps:
git diff --checkbr/tests/download_tools.sh,dumpling/README.md, anddumpling/install.shcurl -I https://download.pingcap.com/tiflash-nightly-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-nightly-linux-amd64.tar.gzcurl -I https://download.pingcap.com/ticdc-nightly-linux-amd64.tar.gzcurl -I http://download.pingcap.com/tidb-enterprise-tools-latest-linux-amd64.tar.gzcurl -I https://download.pingcap.com/tidb-toolkit-latest-linux-amd64.tar.gzcurl -I http://download.pingcap.com/tidb-toolkit-nightly-linux-amd64.tar.gzSide effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.