Ensure we call operation on the most recent view#444
Draft
Ph4ntomas wants to merge 1 commit intopinnacle-comp:mainfrom
Draft
Ensure we call operation on the most recent view#444Ph4ntomas wants to merge 1 commit intopinnacle-comp:mainfrom
Ph4ntomas wants to merge 1 commit intopinnacle-comp:mainfrom
Conversation
problem: it's possible for operate() call to apply on a stale view if a view is pending, leading to some operation failing. solution: There are two part of this fix: 1. Enforce ordering of update and operate message by using the message queue used by message 2. Delay sending operate calls to the server until after the view was sent.
Ph4ntomas
changed the title
Ph4ntomas
force-pushed
the
443-operate-msg-ordering
branch
from
1cb61bd to
10e063d
Compare
Contributor
Author
|
Okay this works as far as I can tell, but I need to check/implement the lua side |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem: it's possible for operate() call to apply on a stale view if a view is pending, leading to some operation failing.
solution: There are two part of this fix:
Fixes: #443