Skip to content

BugFix: fixed frame processor direct mode bug #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

BugFix: fixed frame processor direct mode bug #2737

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
75324f4
fixed frame processor direct mode bug
pranav100000 Sep 24, 2025
73328f1
process task in setup to avoid race condition
pranav100000 Sep 25, 2025
92697af
refactor
pranav100000 Sep 25, 2025
e5f8121
logs
pranav100000 Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/pipecat/processors/frame_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,7 @@ async def __start(self, frame: StartFrame):
self._interruption_strategies = frame.interruption_strategies
self._report_only_initial_ttfb = frame.report_only_initial_ttfb

# Create process task now that we know the direct mode setting
self.__create_process_task()

async def __cancel(self, frame: CancelFrame):
Expand Down Expand Up @@ -886,14 +887,21 @@ async def __input_frame_task_handler(self):

(frame, direction, callback) = await self.__input_queue.get()

if isinstance(frame, SystemFrame):
if isinstance(frame, SystemFrame) or self._enable_direct_mode:
await self.__process_frame(frame, direction, callback)
elif self.__process_queue:
await self.__process_queue.put((frame, direction, callback))
else:
raise RuntimeError(
f"{self}: __process_queue is None when processing frame {frame.name}"
)
# Create process task lazily if it doesn't exist yet
if not hasattr(self, '_FrameProcessor__process_queue') or not self.__process_queue:
logger.debug(f"{self}: Creating process task lazily, direct_mode={self._enable_direct_mode}")
self.__create_process_task()

if hasattr(self, '_FrameProcessor__process_queue') and self.__process_queue:
await self.__process_queue.put((frame, direction, callback))
else:
logger.error(f"{self}: __process_queue still None after creation attempt, direct_mode={self._enable_direct_mode}, frame={frame.name}")
raise RuntimeError(
f"{self}: __process_queue is None when processing frame {frame.name}"
)

self.__input_queue.task_done()

Expand Down