Add comprehensive error handling to OpenAI LLM service #2906
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import ErrorFrame from pipecat.frames.frames - Add catch-all exception handler matching Anthropic service pattern - Handle asyncio.CancelledError by re-raising to maintain proper cancellation - Catch and log all other exceptions with full traceback - Push ErrorFrame upstream on exceptions for error detection - Maintain existing httpx.TimeoutException handling - Ensure LLMFullResponseEndFrame always sent in finally block This change enables consistent error propagation across all LLM services, allowing downstream error monitors to detect failures and implement fallback strategies like LLM hot-switching. Fixes issue where OpenAI service errors were suppressed and not communicated through the frame pipeline, making automatic error recovery impossible.
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
jamsea
requested review from
aconchillo and
markbackman
and removed request for
aconchillo
aconchillo
reviewed
Oct 22, 2025
| await self.start_processing_metrics() | ||
| await self._process_context(context) | ||
| except asyncio.CancelledError: | ||
| raise |
There was a problem hiding this comment.
If we are not doing anything, no need to handle it. By default it's already raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds consistent error propagation to the OpenAI base LLM service, matching the pattern already used in the Anthropic service.
Changes
Problem Solved
Previously, OpenAI LLM service errors were suppressed and not communicated through the frame pipeline. This made it impossible to implement automatic error recovery strategies like LLM hot-switching.
Benefits