add speakers to UserAudioControl dropdown #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds speakers to the device dropdown of the
UserAudioControlcomponent.The idea here is to bring audio device management into one place. The
UserAudioOutputControlcomponent is still available, but not rendered in theConsoletemplate anymore.Furthermore the
noAudioOutputprop is now passed correctly to the underlyingPipecatAppBase.New props for the
UserAudioControlcomponent:noMicrophones: disables microphone selectionnoSpeakers: disables speaker selectionmicrophoneLabel: controls the dropdown label for the microphones sectionspeakerLabel: controls the dropdown label for the speakers sectiondropdownMenuLabel: controls the top dropdown menu label