Confirm session on auth module init against SP #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NameID is not a required attribute that the IdP sends to the SP, so take this in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g., to support IdP-initiated single log out.
This patch adds a step to the module bootstrap to assess if a user is logged in to Moodle via SAML module. If so, determine if the user is still logged in to the SP and compare the SessionIndex value we stored on initial login against the value from the SP. If the user is no longer signed in, or the SessionIndex does not match (which should not be a normal condition, but it's an added safety check) then log the user out of Moodle.