Skip to content

chore: config endpoint may return null for models/mcp servers in the future #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

chore: config endpoint may return null for models/mcp servers in the future #300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions ...cfenv-boot-tanzu-genai/src/main/java/io/pivotal/cfenv/boot/genai/DefaultGenaiLocator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,9 @@ public List<McpConnectivity> getMcpServers() {

private List<ModelConnectivity> getAllModelConnectivityDetails() {
ConfigEndpoint e = getEndpointConfig();
if (e.advertisedModels == null) {
return List.of();
}
return e.advertisedModels
.stream()
.map( a ->
Expand All @@ -239,14 +242,24 @@ private List<ModelConnectivity> getAllModelConnectivityDetails() {
a.capabilities(),
a.labels(),
apiKey,
apiBase + e.wireFormat().toLowerCase())
merge(apiBase, e.wireFormat().toLowerCase()))
)
.toList();
}

private String merge(String apiBase, String wireFormat) {
if (apiBase.endsWith("/")) {
return apiBase + wireFormat;
}
return apiBase + "/" + wireFormat;
}

private List<McpConnectivity> getAllMcpConnectivityDetails() {
return getEndpointConfig()
.advertisedMcpServers
ConfigEndpoint e = getEndpointConfig();
if (e.advertisedMcpServers == null) {
return List.of();
}
return e.advertisedMcpServers
.stream()
.map(m -> new McpConnectivity(m.url()))
.toList();
Expand Down