Skip to content

fix: Sound does not stop when calling stop() in background #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Sound does not stop when calling stop() in background #270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/webaudio/WebAudioInstance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ class WebAudioInstance extends EventEmitter implements IMediaInstance
/** Stops the instance, don't use after this. */
public stop(): void
{
// Unset this property regardless of source
this._pausedReal = false;

if (this._source)
{
this._internalStop();
Expand Down Expand Up @@ -289,7 +292,10 @@ class WebAudioInstance extends EventEmitter implements IMediaInstance
// eslint-disable-next-line no-console
console.assert(end > start, 'End time is before start time');
}

this._paused = false;
this._pausedReal = false;

const { source, gain } = this._media.nodes.cloneBufferSource();

this._source = source;
Expand Down