-
Notifications
You must be signed in to change notification settings - Fork 47
Feat/reduce react aria bundle size #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
naporin0624
wants to merge
10
commits into
main
Choose a base branch
from
feat/reduce-react-aria-bundle-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +1.81 kB (+0.31%) Total Size: 584 kB
ℹ️ View Unchanged
|
|
Visit the preview URL for this PR (updated for commit fb9a198): https://pixiv-charcoal-web--pr750-feat-reduce-react-ar-magqiwxj.web.app (expires Wed, 16 Jul 2025 10:35:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
3fb829d to
f634bf5
Compare
Update mock path from src/utils/useId to src/_lib/useId to match the new directory structure after utilities were reorganized to _lib directory.
Update test snapshots to reflect the new charcoal-visually-hidden class name after the useVisuallyHidden utility was updated to use the new class name.
- Use individual type imports instead of React namespace import in mergeRefs - Replace forEach with for/of loop in mergeRefs for better performance - Fix early return bug in mergeRefs (use continue instead of return) - Rename generatedId to _id in useId for consistency - Use type imports for MutableRefObject and Ref in useObjectRef - Simplify useObjectRef by using mergeRefs utility - Update vitest mock to target _lib/useId instead of React namespace
Remove @react-aria/utils and @react-aria/visually-hidden dependencies and use local implementations from _lib directory to reduce bundle size
Contributor
|
差分的に良さそうです! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
動作確認環境
チェックリスト