Skip to content

Conversation

@Codesleuth
Copy link

Addresses #59

Please let me know if this requires any further work 🙏🏻

Copilot AI review requested due to automatic review settings October 28, 2025 16:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Redis configuration flexibility by allowing users to provide Redis configuration in three ways: as a Redis client instance, as RedisOptions object, or as a connection string URL. This addresses issue #59 by making the plugin more convenient to use when integrating with existing Redis clients.

Key Changes:

  • Modified the redis option type to accept Redis | RedisOptions | string instead of a specific object structure
  • Added type guard function to detect existing Redis client instances
  • Added comprehensive test coverage for all three configuration methods

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/types.ts Updated MCPPluginOptions interface to accept Redis client, options object, or connection string
src/index.ts Added type guard function and logic to handle different Redis configuration formats
test/redis-integration.test.ts Added test cases for Redis client instance and URL string initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Codesleuth Codesleuth requested a review from Copilot October 28, 2025 16:59
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Codesleuth Codesleuth requested a review from Copilot October 28, 2025 17:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Codesleuth Codesleuth changed the title feat: support providing redis client or string feat: support providing redis client or redis URL Oct 29, 2025
@Codesleuth Codesleuth requested a review from Copilot October 29, 2025 11:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant