Initial support for setting autoscaling configuration for environment #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pjcdawkins merged 32 commits into main from rk/set-autoscaling-settings

Sep 12, 2025

+1,008 −71

Contributor

ricardokirkner commented Aug 7, 2025 •

edited

Loading

This PR builds on top of #1549 which should get merged before this one.

ricardokirkner force-pushed the rk/set-autoscaling-settings branch from 04c9dcd to 4576b4c Compare

August 7, 2025 14:30

ricardokirkner mentioned this pull request

Cross-command reference between autoscaling and resources commands #1552

Closed

ricardokirkner requested review from pjcdawkins and akalipetis

August 7, 2025 14:53

ricardokirkner force-pushed the rk/set-autoscaling-settings branch 5 times, most recently from 57c5936 to aea28e7 Compare

August 12, 2025 14:08

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

src/Service/Api.php Outdated Show resolved Hide resolved

ricardokirkner force-pushed the rk/set-autoscaling-settings branch 3 times, most recently from 0823f36 to 507da91 Compare

August 12, 2025 18:32

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

ricardokirkner force-pushed the rk/set-autoscaling-settings branch from 507da91 to 43772cd Compare

August 13, 2025 18:31

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsGetCommand.php Outdated Show resolved Hide resolved

ricardokirkner force-pushed the rk/set-autoscaling-settings branch 2 times, most recently from 9258ce5 to 972a15d Compare

August 18, 2025 13:01

ricardokirkner mentioned this pull request

fix: remove no longer necessary getAutoscalingSettings helper platformsh/platformsh-client-php#98

Open

ricardokirkner requested a review from pjcdawkins

September 3, 2025 18:54

pjcdawkins reviewed

View reviewed changes

src/Service/Api.php Outdated Show resolved Hide resolved

pjcdawkins reviewed

View reviewed changes

src/Service/Api.php Outdated Show resolved Hide resolved

pjcdawkins reviewed

View reviewed changes

src/Service/Api.php Outdated Show resolved Hide resolved

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

pjcdawkins reviewed

View reviewed changes

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

pjcdawkins requested a review from Copilot

September 3, 2025 23:06

pjcdawkins added 3 commits

September 8, 2025 16:01


          Type related fixes

e93414f


          Fix defaults for choice questions

90efec2


          Fix notices when $current is null

69b4a08

pjcdawkins force-pushed the rk/set-autoscaling-settings branch from 5a7587a to 69b4a08 Compare

September 8, 2025 16:35

pjcdawkins and others added 18 commits

September 8, 2025 17:37


          Fix a comment

ad4e3ea


          group threshold/duration/cooldown settings per direction

a1c58b8


          improve UX when configuring autoscaling settings in interacive mode

c60d829


          Better handling and formatting of enabled/disabled status

a1427b5


          Avoid unnecessary white space

02e6446


          Tweak condition for displaying interactive form

ab22284


          Use current autoscaling settings as input defaults

60e5888


          Fix rendering of enabled setting

0a86e50


          Improve autoscaling:get command to display useful information when th…

6abe983

…ere are no autoscaling settings configured


          Show current autoscaling settings when running autoscaling:set command

147d9f1


          Only display actually changed values when configuring new autoscaling…

35fd03d

… settings


          Wording tweak

b5a6f89


          Handle undefined $current and remove unused formatBoolean

c1c85c8


          fix: fail early if managing autoscaling settings is not permitted

bdfd40d


          fix: input durations directly to avoid confusion due to choice indexes

290bb25


          Remove unused variable

3d3b952


          fix: refactor to avoid duplicated logic

0461f4f

Also improve handling of --enabled setting in both interactive and non-interactive flows


          Misc fixes

15f1485

pjcdawkins requested a review from Copilot

September 11, 2025 08:52

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Outdated Show resolved Hide resolved

src/Command/Autoscaling/AutoscalingSettingsSetCommand.php Show resolved Hide resolved

ricardokirkner and others added 4 commits

September 11, 2025 09:24


          fix: handle setting threshold-down only when there is an update avail…

63486e1

…able

Co-authored-by: Copilot <[email protected]>


          fix: code defensively against passing invalid duration to formatDurat…

09eae07

…ionChange

Co-authored-by: Copilot <[email protected]>


          fix: limit supported metrics for autoscaling to cpu

4d3adb0


          fix: formatting related improvements

2fd72e5

- ask for metric name, even when there is only one choice
- render thresholds as %

pjcdawkins merged commit abb87d2 into main

4 checks passed

pjcdawkins deleted the rk/set-autoscaling-settings branch

September 12, 2025 14:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet