Skip to content

schema: the TLS min_version and client_authentication properties are nullable #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025

Conversation

pjcdawkins
Copy link
Contributor

@pjcdawkins pjcdawkins commented Aug 15, 2025

They already had "default": null but null was not an allowed type. Null is allowed by Upsun's actual validation (I have found it used in at least one major deployed project).

@pjcdawkins pjcdawkins requested a review from flovntp August 15, 2025 13:31
Copy link
Member

@akalipetis akalipetis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akalipetis akalipetis merged commit 4c9f603 into main Aug 18, 2025
3 checks passed
@akalipetis akalipetis deleted the update-tls-properties branch August 18, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants