Open
Conversation
Author
|
Is there anything I need to change to get this reviewed; is anything unclear or are there blocking issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a Joomla! 5 template.
The template repo is: https://gitlab.com/woolwichweb/joomla-on-platformsh
Joomla! does not lend itself to being provisioned through a devops environment, such as Platform.sh. So, this template strives to strike a balance between allowing Joomla's self-updating behaviour, while keeping critical code in version control.
We have a production project (albeit a small one) on this, and it works well. Also, I've been provisioning new Platform.sh sites to test the template with new versions of Joomla! and I'm finding it's pretty slick! However, if you have any guidance for how this setup should be changed, let me know.
Thanks for your consideration!