[Codex] Simplify Ch HTTP core#330
Draft
ruslandoga wants to merge 3 commits intomasterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the DBConnection-based internals with a smaller lazy HTTP core built on NimblePool and Mint.
The public core is reduced to starting a pool, running queries, and checking out a connection, with URL stored on the pool and query settings/headers/timeouts supplied per request.
It removes the old connection/query/result/stream modules and DBConnection-specific tests, then adds focused pool and HTTP helper coverage for the new API.
Validated with
mix test.