Handle saving related values if passed as an array of information

[sc0ttkclark]

Examples below use a "books" pick field, multiple select, related to a "book" custom post type created or extended by Pods).

---

Example 1

$pod = pods( 'author', 1234 );

$data = array(
    'books' => array(
        array(
            'post_title' => 'Book 1',
            'post_content' => 'Some content',
            'some_custom_field' => 'Value here',
			'post_status' => 'publish',
        ),
    ),
);

$pod->save( $data );

Expectation would be that the above code would save a new value for the related book field.

---

Example 2

$pod = pods( 'author', 1234 );

$data = array(
    'books' => array(
        array(
            'ID' => 1235,
            'post_title' => 'Book 1',
            'post_content' => 'Some new content',
            'some_custom_field' => 'New value here',
			'post_status' => 'publish',
        ),
    ),
);

$pod->save( $data );

Expectation would be that the above code would update the data for the the related book field.

[JoryHogeveen]

@sc0ttkclark Could you give me a bit more info about the nature of this PR?
What was the bug and how can I replicate that to make sure this PR fixes that?

[sc0ttkclark]

@JoryHogeveen To test this, use the example code. Perhaps we can write tests based on those two?

[pdclark]

Tried example 1 without success.
Relationship field is relating "posts" to "posts", since Pods gives an error for "author" that it's a reserved name.
e.g.,

$pod = pods( 'post', 1 ); // The first post; Hello World.

$pod->save(
	[
		// Multi-select relationship field titled "other_posts".
		'other_posts' => [
			[
				'post_title'     => 'Another Post',
				'post_content'   => '',
				'favorite_color' => '#33ee33', // Color Picker field.
			],
		],
	]
);

Expectation was that it would create another post and assign it to the relationship field on post ID 1.
Didn't work for me. Also didn't report any error and ->save() returned (integer) 1.
@sc0ttkclark

[JoryHogeveen]

@sc0ttkclark @pdclark
I can confirm this feature to work properly. It saves the value correctly in the database but in order to display the value properly there is more required.

1: post_status is required since normally the default status is draft and the default requirement for relationships fields is publish
2: post_type is advised since I assume it will otherwise only work with post relationships since that is the default post type.

Working code:

$pod = pods( 'post', 1 ); // The first post; Hello World.

$pod->save(
	[
		// Multi-select relationship field titled "other_posts".
		'other_posts' => [
			[
				'post_status'    => 'publish',
				'post_type'      => 'post',
				'post_title'     => 'Another Post',
				'post_content'   => '',
				'favorite_color' => '#33ee33', // Color Picker field.
			],
		],
	]
);

[pdclark]

Great thanks Jory.
For some reason it still didn't work for me.
I tried adding a new post on the init hook:

<?php

add_action( 'init', function(){

	$pod = pods( 'post', 1 ); // The first post; Hello World.

	$pod->save(
		[
			// Multi-select relationship field titled "other_posts".
			'other_posts' => [
				[
					'post_status'    => 'publish',
					'post_type'      => 'post',
					'post_title'     => 'Another Post',
					'post_content'   => '',
					'favorite_color' => '#33ee33', // Color Picker field.
				],
			],
		]
	);

});