Skip to content

Conversation

Kevin-Patyk
Copy link
Contributor

Resolves the first part of the Series checklist in: #23448.

The #[allow(unused_mut)] will be removed once I expand the functionality to the other Series strategies.

I tried a more compact technique for selecting types with several options, like UINT and INT. In previous iterations, I would make a bitflag for each respective variant (UInt8, UInt32, etc.) and then a match arm for if they got selected. In this iteration, to prevent repetition, I only have one flag for INT/UINT/FLOAT and one match arm. The arm goes into a strategy that randomly selects one of the variants using proponeof!.

If this is accepted, I can go back to the proptest strategies for DataType and AnyValue and refactor them to make it a bit shorter and less boilerplate. This would also remove the need for nth_set_bit_u64().

Let me know your thoughts. Thank you!

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 19, 2025
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 0% with 92 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.73%. Comparing base (664656e) to head (ad18e2a).
⚠️ Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/series/proptest.rs 0.00% 92 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24549      +/-   ##
==========================================
- Coverage   81.76%   81.73%   -0.03%     
==========================================
  Files        1684     1685       +1     
  Lines      229458   229550      +92     
  Branches     2952     2952              
==========================================
+ Hits       187616   187634      +18     
- Misses      41099    41173      +74     
  Partials      743      743              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ritchie46 ritchie46 force-pushed the main branch 3 times, most recently from ddf5907 to d0914d4 Compare September 27, 2025 11:06
@coastalwhite coastalwhite merged commit 7e61f20 into pola-rs:main Sep 29, 2025
23 checks passed
@coastalwhite
Copy link
Collaborator

Thank you very much @Kevin-Patyk. Sorry for the slow reviews, it has been quite hectic here.

@Kevin-Patyk
Copy link
Contributor Author

Thank you very much @Kevin-Patyk. Sorry for the slow reviews, it has been quite hectic here.

No worries @coastalwhite. I saw all the updates about cloud coming out and was assuming it was very busy :)

@Kevin-Patyk Kevin-Patyk deleted the chore/add_proptest_series_physical branch October 10, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal An internal refactor or improvement rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants