Skip to content

Comments

feat(rust): Implement predicate pushdown for aliased groupby keys#26597

Open
jberg5 wants to merge 3 commits intopola-rs:mainfrom
jberg5:fix/groupby-alias-predicate-pushdown
Open

feat(rust): Implement predicate pushdown for aliased groupby keys#26597
jberg5 wants to merge 3 commits intopola-rs:mainfrom
jberg5:fix/groupby-alias-predicate-pushdown

Conversation

@jberg5
Copy link
Contributor

@jberg5 jberg5 commented Feb 17, 2026

Addresses #26589.

Previously, predicate pushdown for group_by queries when the group by key was aliased was unimplemented.

AI use: I used Claude with Opus 4.6 to identify this opportunity, implement the test case, and implement the fix. I have verified its correctness myself; I don't think I could have done a better job with the code if I had written this by hand (low bar - I spend a lot more time with Python than I do with Rust 😄 ).

@jberg5 jberg5 changed the title Implement predicate pushdown for aliased groupby keys feat(rust): Implement predicate pushdown for aliased groupby keys Feb 17, 2026
@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature rust Related to Rust Polars and removed title needs formatting labels Feb 17, 2026
@codecov
Copy link

codecov bot commented Feb 17, 2026

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.40%. Comparing base (ceb6366) to head (fc8534a).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
...src/plans/optimizer/predicate_pushdown/group_by.rs 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #26597      +/-   ##
==========================================
+ Coverage   81.38%   81.40%   +0.02%     
==========================================
  Files        1792     1795       +3     
  Lines      244406   244988     +582     
  Branches     3078     3079       +1     
==========================================
+ Hits       198911   199444     +533     
- Misses      44709    44758      +49     
  Partials      786      786              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or an improvement of an existing feature rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant