feat(rust): Implement predicate pushdown for aliased groupby keys#26597
Open
jberg5 wants to merge 3 commits intopola-rs:mainfrom
Open
feat(rust): Implement predicate pushdown for aliased groupby keys#26597jberg5 wants to merge 3 commits intopola-rs:mainfrom
jberg5 wants to merge 3 commits intopola-rs:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26597 +/- ##
==========================================
+ Coverage 81.38% 81.40% +0.02%
==========================================
Files 1792 1795 +3
Lines 244406 244988 +582
Branches 3078 3079 +1
==========================================
+ Hits 198911 199444 +533
- Misses 44709 44758 +49
Partials 786 786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #26589.
Previously, predicate pushdown for group_by queries when the group by key was aliased was unimplemented.
AI use: I used Claude with Opus 4.6 to identify this opportunity, implement the test case, and implement the fix. I have verified its correctness myself; I don't think I could have done a better job with the code if I had written this by hand (low bar - I spend a lot more time with Python than I do with Rust 😄 ).