docs(py-polars): clarify delta_write_options for compression#26619
Open
cluster2600 wants to merge 2 commits intopola-rs:mainfrom
Open
docs(py-polars): clarify delta_write_options for compression#26619cluster2600 wants to merge 2 commits intopola-rs:mainfrom
cluster2600 wants to merge 2 commits intopola-rs:mainfrom
Conversation
cluster2600
requested review from
MarcoGorelli,
alexander-beedie,
c-peters and
ritchie46
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #26619 +/- ##
=======================================
Coverage 81.37% 81.38%
=======================================
Files 1794 1794
Lines 245003 245003
Branches 3080 3080
=======================================
+ Hits 199382 199405 +23
+ Misses 44835 44812 -23
Partials 786 786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20739.
The
delta_write_optionsparameter is forwarded todeltalake.write_deltalake, but compression is configured viadeltalake.WriterProperties(passed as thewriter_propertiesoption).This PR clarifies the docstring so users don't expect
delta_write_options={"compression": ...}to work.