feat: Add ignore_nulls to {list,arr}.{any,all}#27186
Open
coastalwhite wants to merge 5 commits intopola-rs:mainfrom
Open
feat: Add ignore_nulls to {list,arr}.{any,all}#27186coastalwhite wants to merge 5 commits intopola-rs:mainfrom
ignore_nulls to {list,arr}.{any,all}#27186coastalwhite wants to merge 5 commits intopola-rs:mainfrom
Conversation
Fixes pola-rs#16764. This PR dispatches `{list,arr}.{any,all}` to `{list,arr}.agg(pl.element().{any,all}()` removing a bunch of code and giving us the `ignore_nulls` flag for free. This still should be efficient (although maybe a tiny bit less) as this will go through the group aggregation evaluation engine.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27186 +/- ##
==========================================
+ Coverage 80.85% 81.71% +0.85%
==========================================
Files 1816 1814 -2
Lines 250589 250439 -150
Branches 3147 3147
==========================================
+ Hits 202618 204649 +2031
+ Misses 47166 44985 -2181
Partials 805 805 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ritchie46
approved these changes
Apr 7, 2026
Member
ritchie46
left a comment
There was a problem hiding this comment.
Seems good to me. I'd rather improve the generic path performance indeed. We need to wait merging until we can break DSL.
Member
|
Just for my sanity, the generic list aggregation path is marked as elementwise, right? |
Collaborator
Author
Indeed, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16764.
This PR dispatches
{list,arr}.{any,all}to{list,arr}.agg(pl.element().{any,all}()removing a bunch of code and giving us theignore_nullsflag for free. This still should be efficient (although maybe a tiny bit more memory), as this will go through the group aggregation evaluation engine.No AI was used.