Skip to content

feat(rust)!: removed lossy type coercion for primitive numeric types … #27197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dhvish wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(rust)!: removed lossy type coercion for primitive numeric types … #27197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 26 additions & 38 deletions crates/polars-plan/src/plans/conversion/type_coercion/is_in.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,46 +147,34 @@ See https://github.com/pola-rs/polars/issues/22149 for more information."
return Ok(None);
},

// don't attempt to cast between obviously mismatched types, but
// allow integer/float comparison (will use their supertypes).
(a, b) => {
if (a.is_primitive_numeric() && b.is_primitive_numeric()) || (a == &DataType::Null) {
if a != b {
// @TAG: 2.0
// @HACK: `is_in` does supertype casting between primitive numerics, which
// honestly makes very little sense. To stay backwards compatible we keep this,
// but please in 2.0 remove this. FirstArgLossless might be a good alternative,
// as used by index_of(), or build on index_of().
//
// Try lossless supertype first to avoid precision loss (e.g.,
// UInt64 + Int64 would otherwise become Float64), then fall back
// to the existing supertype behavior.
let super_type = polars_core::utils::get_numeric_upcast_supertype_lossless(
&type_left,
type_other_inner,
)
.map_or_else(
|| polars_core::utils::try_get_supertype(&type_left, type_other_inner),
Ok,
)?;

let other_type = match &type_other {
DataType::List(_) => DataType::List(Box::new(super_type.clone())),
#[cfg(feature = "dtype-array")]
DataType::Array(_, width) => {
DataType::Array(Box::new(super_type.clone()), *width)
},
_ => unreachable!(),
};

return Ok(Some(IsInTypeCoercionResult::SuperType(
super_type, other_type,
)));
}
// Only do lossless coercion for primitive numerics; keep existing Null
// behavior by resolving its supertype against the inner right dtype.
let super_type = if a.is_primitive_numeric() && b.is_primitive_numeric() {
polars_core::utils::get_numeric_upcast_supertype_lossless(
&type_left,
type_other_inner,
)
.ok_or_else(
|| polars_err!(InvalidOperation: "'{op}' cannot check for {:?} values in {:?} data",&type_left, &type_other)
)?
} else if a == &DataType::Null {
polars_core::utils::try_get_supertype(&type_left, type_other_inner)?
} else {
polars_bail!(
InvalidOperation: "'{op}' cannot check for {:?} values in {:?} data", &type_other, &type_left
)
};
let other_type = match &type_other {
DataType::List(_) => DataType::List(Box::new(super_type.clone())),
#[cfg(feature = "dtype-array")]
DataType::Array(_, width) => DataType::Array(Box::new(super_type.clone()), *width),
_ => unreachable!(),
};

return Ok(None);
}
polars_bail!(InvalidOperation: "'{op}' cannot check for {:?} values in {:?} data", &type_other, &type_left)
return Ok(Some(IsInTypeCoercionResult::SuperType(
super_type, other_type,
)));
},
};
Ok(Some(casted_expr))
Expand Down
Loading