refactor(rust): Refactor coalesce_columns and add coalesce_binary_columns#27251
Open
mansanlab wants to merge 2 commits intopola-rs:mainfrom
Open
refactor(rust): Refactor coalesce_columns and add coalesce_binary_columns#27251mansanlab wants to merge 2 commits intopola-rs:mainfrom
coalesce_columns and add coalesce_binary_columns#27251mansanlab wants to merge 2 commits intopola-rs:mainfrom
Conversation
The new code fixes a bug where the null check was always evaluating incorrectly, meaning the early exit never fired as intended. It also adds several shortcuts to skip expensive operations when a column is null or has no nulls and handles scalar broadcasting that the old code ignored. This replaces the sequential loop with a parallel tree reduction for multi-column inputs, resolving the TODO comment the original author left behind.
coalesce_columns and add coalesce_binary_columns
coalesce_columns and add coalesce_binary_columnscoalesce_columns and add coalesce_binary_columns
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27251 +/- ##
==========================================
+ Coverage 81.56% 81.88% +0.31%
==========================================
Files 1820 1820
Lines 251061 251093 +32
Branches 3149 3149
==========================================
+ Hits 204788 205601 +813
+ Misses 45465 44684 -781
Partials 808 808 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new code fixes a bug where the null check was always evaluating incorrectly, meaning the early exit never fired as intended. It also adds several shortcuts to skip expensive operations when a column is null or has no nulls and handles scalar broadcasting that the old code ignored. This replaces the sequential loop with a parallel tree reduction for multi-column inputs, resolving the TODO comment the original author left behind.